🚮 Stop loading pv endpoint from MGID AMP stories #40192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@powerivq There are some problems with tests, which seems are not related to our changes |
|
@velichkin See that. Please rebase against latest main. |
velichkin
force-pushed
the
VT-29958-2
branch
from
b880c34 to
d6898f8
Compare
|
@powerivq Done, but errors are still there |
|
@velichkin we are actively working on that. |
|
@velichkin Please rebase again, and also remove the following imports: createElementWithAttributes and hasOwn |
|
@powerivq done |
powerivq
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer need to call amp-pixel with https://c.mgid.com/pv/, so it should be removed.